From feb1828141d0274d409ecb165a6751e5c713f459 Mon Sep 17 00:00:00 2001 From: Ilya Kreymer Date: Tue, 4 Oct 2022 17:12:10 -0700 Subject: [PATCH] app loading: load external URLs from not found page using default browser update CHANGES.md --- CHANGES.md | 3 ++- src/electron-replay-app.js | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 0ef484a..90e8671 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -12,7 +12,8 @@ v1.7.0 - Embeds: Add 'requireSubdomainIframe' embed attribute to only allow embed if loaded from a cross-origin / subdomain iframe. - UI: improved formatting on 404 not found page. - Loading: Fix IPFS loading, use auto-js-ipfs to load from an IPFS gateway or existing local instance (don't run local node for now) -- Dependencies: update to wabac.js 2.13.0 to support verification, latest wombat (3.3.9) +- Loading: App: Load 'not found' URLs from error page using default browser +- Dependencies: update to wabac.js 2.13.2 to support verification, latest wombat (3.3.9) v1.6.5 - Loading: Don't ignore hashtag, eg. #.wacz to specify file type when loading (via wabac.js) diff --git a/src/electron-replay-app.js b/src/electron-replay-app.js index 5955d5f..9932718 100644 --- a/src/electron-replay-app.js +++ b/src/electron-replay-app.js @@ -168,6 +168,12 @@ class ElectronReplayApp return { action: "deny"}; } + // load external URLs in native browser + if (!url.startsWith(STATIC_PREFIX)) { + shell.openExternal(url); + return { action: "deny"}; + } + return { action: "allow"}; }); });