From dd70bc722f0644f4af01396d71f356a1daaa414b Mon Sep 17 00:00:00 2001 From: sua yoo Date: Wed, 16 Aug 2023 18:57:11 -0700 Subject: [PATCH] Lint and fix Lit html (#216) - Adds eslint lit plugin to catch linting errors in lit html - Fixes linting errors --- .eslintrc.js | 4 + _data/package.json | 1 + package.json | 1 + src/coll-index.js | 20 +- src/embed-receipt.js | 185 +- src/loader.js | 6 +- src/pages.js | 92 +- src/replay.js | 2 +- src/url-resources.js | 344 ++-- sw.js | 20 +- ui.js | 4511 +++++++++++++++++++++++++----------------- yarn.lock | 26 + 12 files changed, 3095 insertions(+), 2117 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index dd14bd8..6773c70 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -5,8 +5,12 @@ module.exports = { }, "extends": [ "eslint:recommended", + "plugin:lit/recommended", "prettier" ], + "plugins": [ + "lit" + ], "parserOptions": { "ecmaVersion": 2018, "sourceType": "module" diff --git a/_data/package.json b/_data/package.json index 260a774..21c4e54 100644 --- a/_data/package.json +++ b/_data/package.json @@ -35,6 +35,7 @@ "electron-notarize": "^1.1.1", "eslint": "^8.23.1", "eslint-config-prettier": "^9.0.0", + "eslint-plugin-lit": "^1.9.1", "http-server": "^13.0.2", "husky": "^8.0.0", "lint-staged": "^14.0.0", diff --git a/package.json b/package.json index 260a774..21c4e54 100644 --- a/package.json +++ b/package.json @@ -35,6 +35,7 @@ "electron-notarize": "^1.1.1", "eslint": "^8.23.1", "eslint-config-prettier": "^9.0.0", + "eslint-plugin-lit": "^1.9.1", "http-server": "^13.0.2", "husky": "^8.0.0", "lint-staged": "^14.0.0", diff --git a/src/coll-index.js b/src/coll-index.js index e007015..7c5fe6c 100644 --- a/src/coll-index.js +++ b/src/coll-index.js @@ -292,12 +292,11 @@ class CollIndex extends LitElement { class="input is-small" @input="${(e) => (this.query = e.currentTarget.value)}" .value="${this.query}" - type="text" placeholder="Search by Archive Title or Source" /> - + + + ` - : html` - Deleting + Deleting + `} `, )} @@ -446,9 +448,9 @@ class CollInfo extends LitElement { : html` ${coll.sourceUrl} `} - + + + ${coll.sourceUrl && coll.sourceUrl.startsWith("googledrive://") ? html`

(${coll.filename})

` : ""} diff --git a/src/embed-receipt.js b/src/embed-receipt.js index 64601a3..71f27bc 100644 --- a/src/embed-receipt.js +++ b/src/embed-receipt.js @@ -203,45 +203,76 @@ export class RWPEmbedReceipt extends LitElement { const dateStr = tsToDate(this.ts).toLocaleString(); return html` -