ui tweaks for downstream (archiveweb.page):

- don't show page editing options when in sidebar mode
- don't autorefresh in replay and sidebar not visibile
- disable plugins by default now

CHANGES.md

@@ -2,7 +2,7 @@
 
 v1.3.9 (tip)
 - Fidelity: Upgrade to wabac.js 2.6.0-beta.0, wombat 3.1.0: improved POST request rewriting for multipart/form-data, Tableau dashboard fidelity
-- UI: style fix on page delete spinner (editable mode)
+- UI: editable mode: style fix on page delete spinner, don't show editing options on sidebar
 
 v1.3.8
 - UI: Native files: Support asking permission when doing a full reload of a local file.

src/coll.js

@@ -146,7 +146,7 @@ class Coll extends LitElement
     }
     if (changedProperties.has("editable")) {
       if (this.editable) {
-        this._pollColl = setInterval(() => this.doUpdateInfo(), 10000);
+        this._pollColl = setInterval(() => this.doUpdateInfo(true), 10000);
       } else if (this._pollColl) {
         clearInterval(this._pollColl);
       }
@@ -230,7 +230,13 @@ class Coll extends LitElement
     }
   }
 
-  async doUpdateInfo() {
+  async doUpdateInfo(autorefresh = false)
+  {
+    // if auto-refresh, and replay and no sidebar, than skip update
+    if (autorefresh && this.tabData.url && !this.showSidebar) {
+      return;
+    }
+
     let coll = this.loadInfo && this.loadInfo.customColl;
 
     if (!coll) {

src/electron-main.js

@@ -8,4 +8,4 @@ const replayApp = new ElectronReplayApp({
   profileName: "replaywebpage"
 });
 
-replayApp.init();
+replayApp.init(true);

src/electron-replay-app.js

@@ -87,7 +87,7 @@ class ElectronReplayApp
     return "index.html";
   }
 
-  init() {
+  init(includePlugins = false) {
     // Single instance check
     const gotTheLock = app.requestSingleInstanceLock();
 
@@ -101,30 +101,35 @@ class ElectronReplayApp
       });
     }
 
-    switch (process.platform) {
+    if (includePlugins) {
-      case 'win32':
+      switch (process.platform) {
-        this.pluginPath = path.join(this.projPath, "plugins-win", `pepflashplayer-x86${process.arch === 'x64' ? '_64' : ''}.dll`);
+        case 'win32':
-        break;
+          this.pluginPath = path.join(this.projPath, "plugins-win", `pepflashplayer-x86${process.arch === 'x64' ? '_64' : ''}.dll`);
-  
+          break;
-      case 'darwin':
+    
-        this.pluginPath = path.join(this.projPath, "plugins-mac", "PepperFlashPlayer.plugin");
+        case 'darwin':
-        break;
+          this.pluginPath = path.join(this.projPath, "plugins-mac", "PepperFlashPlayer.plugin");
-  
+          break;
-      case 'linux':
+    
-        this.pluginPath = path.join(this.projPath, "plugins-mac", "libpepflashplayer.so");
+        case 'linux':
-        break;
+          this.pluginPath = path.join(this.projPath, "plugins-mac", "libpepflashplayer.so");
-  
+          break;
-      default:
+    
-        console.log('platform unsupported: ' + process.platform);
+        default:
-        break;
+          console.log('platform unsupported: ' + process.platform);
-    }
+          break;
+      }
 
-    app.commandLine.appendSwitch('ppapi-flash-path', this.pluginPath);
+      app.commandLine.appendSwitch('ppapi-flash-path', this.pluginPath);
+    }
 
     console.log('app path', this.appPath);
     console.log('dir name', __dirname);
     console.log('proj path', this.projPath);
-    console.log('plugin path', this.pluginPath);
+
+    if (includePlugins) {
+      console.log('plugin path', this.pluginPath);
+    }
 
     console.log('app data', app.getPath('appData'));
     console.log('user data', app.getPath('userData'));

src/pageentry.js

@@ -182,8 +182,10 @@ class PageEntry extends LitElement
 
     const hasSize = typeof(p.size) === "number";
 
+    const editable = this.editable && !this.isSidebar;
+
     return html`
-    ${this.editable ? html`
+    ${editable ? html`
     <div class="check-select">
       <label class="checkbox">
       <input @change=${this.onSendSelToggle} type="checkbox" .checked="${this.selected}">
@@ -229,7 +231,7 @@ class PageEntry extends LitElement
       </div>
     </div>
 
-    ${this.editable ? html`
+    ${editable ? html`
       ${!this.deleting ? html`
       <button @click="${this.onSendDeletePage}" class="delete"></button>` : html`
       <button class="button delete is-loading is-static"></button>

src/pages.js

@@ -614,7 +614,7 @@ class Pages extends LitElement
 
   renderPageHeader() {
     return html`
-    ${this.editable && this.filteredPages.length ? html`
+    ${!this.isSidebar && this.editable && this.filteredPages.length ? html`
     <div class="check-select">
       <label class="checkbox">
       <input @change=${this.onSelectAll} type="checkbox" .checked="${this.allSelected}">