archivalo-oss/replayweb.page
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Typescript config parity with Browsertrix repo (#289)

Browse Source 
Follow-up from #288 

This matches the strictness rules with the Browsertrix repo,
specifically `noImplicitAny`, and then adds `// @ts-expect-error`s to
suppress existing errors this change raises. This'll help us keep code
quality high moving forward.

Going to just directly merge this once it passes CI; as with #288, this
doesn't change any code, just comments.
This commit is contained in:
Emma Segal-Grossman
2024-03-07 21:12:26 -05:00
committed by GitHub
parent 40d84f3383
commit 5c7b914e69
21 changed files with 121 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/embed.ts
+6
View File
@@ -24,7 +24,9 @@ class Embed extends LitElement {
@property({ type: String }) ts = "";
@property({ type: String }) query = "";
// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7008 - Member 'source' implicitly has an 'any' type.
@property({ type: String }) source;
// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7008 - Member 'src' implicitly has an 'any' type.
@property({ type: String }) src;
@property({ type: String }) view = "replay";
@@ -57,6 +59,7 @@ class Embed extends LitElement {
| string
| undefined;
// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7008 - Member 'requireSubdomainIframe' implicitly has an 'any' type.
@property({ type: Boolean }) requireSubdomainIframe;
@property({ type: String }) loading = "";
@@ -73,6 +76,7 @@ class Embed extends LitElement {
isCrossOrigin: boolean | undefined;
swmanager: SWManager | undefined;
// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'replayfile' implicitly has an 'any' type.
static setDefaultReplayFile(replayfile) {
defaultReplayFile = replayfile;
}
@@ -109,6 +113,7 @@ class Embed extends LitElement {
}
}
// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
handleMessage(event) {
const iframe = this.renderRoot.querySelector("iframe");
@@ -353,6 +358,7 @@ class Embed extends LitElement {
`;
}
// @ts-expect-error [// TODO: Fix this the next time the file is edited.] - TS7006 - Parameter 'event' implicitly has an 'any' type.
onLoad(event) {
if (this.isCrossOrigin) {
return;