ESLint parity with the Browsertrix repo (#288)

This copies the rules from the Browsertrix repo, and uses
[`suppress-eslint-errors`](https://www.npmjs.com/package/suppress-eslint-errors)
to suppose the violations. I'll take a pass at cleaning this up at some
point in the future, and let's do our best to address these in the
future as we come across them :)

This'll help ensure new code being added to this repo is held to the
same standard as code in Browsertrix's frontend.
This commit is contained in:
Emma Segal-Grossman
2024-03-07 20:12:50 -05:00
committed by GitHub
parent 57123e8a63
commit 40d84f3383
21 changed files with 315 additions and 37 deletions
+8
View File
@@ -117,6 +117,8 @@ class URLResources extends LitElement {
}
_timedUpdate() {
// TODO: Fix this the next time the file is edited.
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (this.newQuery !== null) {
this.query = this.newQuery;
this.newQuery = null;
@@ -129,6 +131,8 @@ class URLResources extends LitElement {
changedProperties.has("urlSearchType") ||
changedProperties.has("currMime")
) {
// TODO: Fix this the next time the file is edited.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.doLoadResources();
const data = {
query: this.query,
@@ -188,6 +192,8 @@ class URLResources extends LitElement {
`${this.collInfo!.apiPrefix}/urls?${params.toString()}`,
);
const data = await resp.json();
// TODO: Fix this the next time the file is edited.
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
this.results = isMore ? this.results.concat(data.urls) : data.urls;
// can be more than count if multiple mimes
this.tryMore = data.urls.length >= count;
@@ -229,6 +235,8 @@ class URLResources extends LitElement {
const diff =
element.scrollHeight - element.scrollTop - element.clientHeight;
if (this.tryMore && diff < 40) {
// TODO: Fix this the next time the file is edited.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.doLoadResources(true);
}
}