feat: Add "not found" error detail on page load (#482)

Resolves https://github.com/webrecorder/replayweb.page/issues/481 with
workaround
Related to https://github.com/webrecorder/browsertrix/issues/2865

## Changes

- Includes `replayNotFoundError` in `"page-loading"` event when page is
finished loading as a workaround for the actual `replayNotFoundError`
value not being available on `urlchange`.
- Minor refactor to more strongly typed events.
This commit is contained in:
sua yoo
2026-02-11 23:58:28 -08:00
committed by GitHub
parent e4fd230694
commit 17539f3084
11 changed files with 136 additions and 54 deletions
+9 -2
View File
@@ -10,6 +10,7 @@ import "keyword-mark-element/lib/keyword-mark.js";
import { type ItemType } from "./types";
import { type URLResource } from "./types";
import { dateTimeFormatter } from "./utils/dateTimeFormatter";
import type { TabNavEvent } from "./events";
// ===========================================================================
/**
@@ -145,7 +146,9 @@ class URLResources extends LitElement {
!changedProperties.has("currMime") &&
!changedProperties.has("urlSearchType");
this.dispatchEvent(
new CustomEvent("coll-tab-nav", { detail: { replaceLoc, data } }),
new CustomEvent<TabNavEvent["detail"]>("coll-tab-nav", {
detail: { replaceLoc, data },
}),
);
}
@@ -613,7 +616,11 @@ class URLResources extends LitElement {
ts: event.currentTarget.getAttribute("data-ts"),
};
this.dispatchEvent(new CustomEvent("coll-tab-nav", { detail: { data } }));
this.dispatchEvent(
new CustomEvent<TabNavEvent["detail"]>("coll-tab-nav", {
detail: { data },
}),
);
return false;
}
}